Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove post type quote & picture #1099

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Remove post type quote & picture #1099

merged 2 commits into from
Aug 16, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Aug 16, 2019 •
edited
Loading

Configuration

For now users can disable the display of post header by setting header to false in Front-matter

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang
Copy link
Contributor Author

It's not even a breaking change because there's no docs for parameter type in post Front-matter.

@stevenjoezhang stevenjoezhang added this to the v7.4.0 milestone Aug 16, 2019
@1v9
Copy link
Member

1v9 commented Aug 16, 2019

The post type is rarely used by people, removing this is acceptable for me. Maybe in the future we can recreate this feature.

@stevenjoezhang stevenjoezhang merged commit 92fdf86 into master Aug 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the post branch August 16, 2019 02:52
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Remove post type quote & picture (theme-next#1099)
57226a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1v9 1v9 1v9 approved these changes

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

Assignees
No one assigned
Labels
Configurations ⭐ Feature
Projects
None yet
Milestone
v7.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenjoezhang @1v9